feat: switch to armv7 #188
Open
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Node dropped support for armv6 since Node 12 1
most devices run on armv7. other than some very old raspberry pis.
many repos only build for armv7.
Changes
this pr keeps the old package name, which could create ambiguity.
it also reformats the target override logic, to match the bun workaround
Notes
PR #186 would break, even tho I think its a good solution.
But it seems that #182 already hardcodes the import strings (which would make #186 obsolete) but development has stopped
Footnotes
https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list ↩